Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skeleton for new websockets stream api docs #1074

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

illia-malachyn
Copy link

@illia-malachyn illia-malachyn commented Jan 7, 2025

Closes onflow/flow-go#6644

  • Added a single page overview docs
  • Added a multi-page detailed docs for each message type

This is in progress and is postponed till we finish with websockets epic. However, you can review it and write notes about it.

What to add to:

  • more examples with different parameters (after integration tests are finished)
  • rate limits (when all limits are discussed and implemented)

* Added a single page overiview docs
* Added a multi-page detailed docs for each
message type
Copy link

vercel bot commented Jan 7, 2025

@illia-malachyn is attempting to deploy a commit to the Flow Team on Vercel.

A member of the Team first needs to authorize it.

@illia-malachyn
Copy link
Author

illia-malachyn commented Jan 7, 2025

Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 9:09pm

@franklywatson franklywatson marked this pull request as ready for review January 11, 2025 02:04
@franklywatson
Copy link
Contributor

@illia-malachyn the deployed vercel from a few days ago is here.

With the left nav we probably want a top label that is more readable than "websockets-stream-api". This nav option is also distinct from the written title of 'Websockets Stream API'. My guess is the intention was for the sub pages to be under that root, not the 'websockets-stream-api' one

Screenshot 2025-01-13 at 11 26 32 AM Screenshot 2025-01-13 at 11 23 54 AM

@franklywatson
Copy link
Contributor

franklywatson commented Jan 15, 2025

Nav looks good in latest vercel deployment. Looks like there's still more to be added and we should wait to merge this only once the functionality is deployed and live.

Use any WebSocket client library to connect to the endpoint. Below is an example using JavaScript:

```javascript
const ws = new WebSocket('wss://api.flow.com/ws');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use the correct url or an obviously fake one.

Copy link
Author

@illia-malachyn illia-malachyn Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is it ? wss://rest-mainnet.onflow.org/ws ?

Comment on lines 22 to 24
- Each connection supports up to 10 concurrent subscriptions. Exceeding this limit will result in an error.
- Each subscription may provide up to 5 responses per second.
- After 1 minute of inactivity (no data is sent to/read from connection) connection is closed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should make all of these configurable, and just list the values used on the public access nodes here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I use up-to-date values here, or provide a link to the code where the defaults are set, or maybe scrap the values from the flow-go repo ?

@franklywatson franklywatson linked an issue Jan 29, 2025 that may be closed by this pull request
@franklywatson
Copy link
Contributor

@illia-malachyn you will need to merge from main since the project structure for the docs in this area changed.

Also, we need to make sure this section is also updated: https://developers.flow.com/networks/access-onchain-data#subscriptions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Access] Add documentation for new websockets [Access] Add examples for ws conn usages
5 participants